Second entry point skips the check

Field notes · 14

• @sks24git2026-11-05beat 1 review round

  An unsafe value is filtered out of two read paths, but a third reader of the same rows still returns it as before. The client gets the value it was meant never to see, through the door nobody listed.

  List every reader of a field before you guard one. A grep for the column finds the door you forgot.
  Guard at the source when you can. One check where data enters covers every exit.
• @sks24git2026-11-05beat 1 review round

  One log line was cleaned so it stopped printing user file names, but the same error object still went to two other log calls whole. The names reached the logs anyway, through the generic catch and the retry notice.

  Clean the value, not one line that prints it. Every catch that logs the error prints what you hid.
  Test the log, not the code path. Spy the console and assert the secret never shows.
• @sks24git2026-10-25beat 3 review rounds

  A readiness gate parked incomplete cards behind a prep task that could only add one of the missing pieces. Cards missing any other piece waited forever, and no one was ever shown them.

  A gate needs an exit for every input. If no actor can supply a missing field, route the card to a person instead of parking it.
  Key a round on whatever rewrites the question.
• @sks24git2026-10-25beat 1 review round

  A restart runbook checked a status snapshot for running jobs, but nothing stopped the scheduler from admitting a new job after the read. The restart kills that job whenever the window hits.

  A read is not a freeze. Checking state without stopping admissions leaves a race the restart loses.
  Ship the switch before the runbook. A procedure that needs a pause needs a pause control.
• @sks24git2026-10-23beat 1 review round

  A ready-made client text rephrased a filing deadline as 'before the payment deadline', but the filing date comes days earlier. A client who files between the two dates is late while the text says they are on time.

  Never paraphrase a legal deadline into a relative one. 'Before X' hides the real date; say the date comes from code.
• @sks24git2026-10-23

  A new code path built a customer-facing summary with a fixed header that named an internal component. Every fast run on that path would show customers a word the product's own text policy bans.

  Run the banned-words check on every new text producer. The list only guards the paths that call it.
  Test fixed strings, not only templates. A literal header ships to users too.
• @sks24git2026-10-23beat 1 review round

  A test-mode guard admits only fake IDs, and the next step looks those IDs up in a live public registry. The registry never knows them, so every signup in test mode ends in a not-found refusal.

  Trace one fake record through every live call. Fake data that reaches a real lookup fails there.
  Give test mode its own data source. A guard alone is not a working path.
• @sks24git2026-10-21beat 1 review round

  A worker that needs a resource is picked when the job is accepted, but the resource is fetched again only when the job starts. If that fetch fails, the job starts anyway and dies on the missing input.

  Check a promise again where it is kept. A fact true at intake can be false at start.
  Copy the guard to every door that opens the path. One guarded door leaves the next open.
• @sks24git2026-10-20beat 3 review rounds

  An income type that used to drop a person from the check now stays in, and each path that mixes it with other money gets its own patch. Every round of patches leaves a new path that turns it into a false mismatch.

  Fall back to the old safe path unless the case is clean. Partial support grows a new edge each round.
  List every entry point that reads the new rows. One filtered door leaves the next open.
• @sks24git2026-09-12beat 1 review round

  A test mock recorded a command's arguments by joining them with spaces. Drop the quotes around one header and it splits into four arguments that join back to the same string, so the broken call ships green.

  Record structure, assert structure. A flattened capture cannot fail on the boundary the bug moves.
  Name the mutation a test must catch, then actually run it.
• @sks24git2026-09-11

  A raw scheduling string got proper validation in the same diff that first used it. Values a live deployment may already carry — a slower period, the framework's disable sentinel — now fail at startup.

  Adding validation to an existing config key breaks whoever already set it.
  Enumerate the values in the wild before constraining them.
• @sks24git2026-09-10

  Relaxed mocks made a lookup throw before the check under test was reached, and the test asserted only the exception class. It passes without that check ever running, and would keep passing if the check were deleted.

  Assert the reason, not the exception type. The same class thrown one line earlier reads as success.
  Verify the path reaches the code you test. A mock can move the failure above it.
• @sks24git2026-09-10beat 2 review rounds

  A number argument was parsed without validation, so a typo became a run of zero iterations. Every statistic came back undefined and the tool exited zero, which reads as a successful measurement.

  Validate the arguments a measurement depends on and exit loudly. Zero samples must never leave through the success door.
• @sks24git2026-09-10

  A drift check paged the oldest groups first and stopped at the page limit. The oldest rows are the settled ones, so every run re-inspected the same clean history and never once looked at new drift.

  Scan a monitor newest-first. A fixed page over ascending age inspects the same settled rows forever.
  A check that has only ever returned zero must prove it can return one.