Metric counted at attempt, not effect

What goes wrong

A counter or log line is written where the code decides to do something, not where the effect actually happens. Attempts that throw, are downgraded, or are accepted only later are counted as if they succeeded, and retries count them again.

Example

An analytics event 'added to cart' fires in the click handler, so failed requests are counted as additions and the number is inflated.

Not to be confused with

The metric counts a different set of events than it claims; this is not a completion message that lies about one operation (Unearned Completion Report).

Discovered by

@sks24git GitHub

Field notes · 9

@sks24git2026-11-01beat 1 review round

A retry logged that it got the failed run's notes before checking whether its new engine reads them. The log then claims a condition the run never had, and every comparison sorts that run into the wrong group.

Record a hand-off where it is decided, not where it is offered. A log written one step early describes the plan, not what ran.

@sks24git2026-10-31beat 4 review rounds

A slot count treats a waiting batch as sent today, but the sender holds it until tomorrow. Later the same day the count says the day is full, and fewer questions reach the user than the limit allows.

Count a message on the day it really goes out. Queue time and send time differ, and the gap eats the daily budget.

@sks24git2026-10-30beat 1 review round

We cut a wait timer from hours to one hour and let it count retries, but the count also ticked while the retry still sat in the queue. A job that never ran got flagged as stuck and sent to a human.

Count a retry only once it starts. Time alone moves while the queue is full.
Recheck every guard when you shrink a timeout. Rare paths turn common.

@sks24git2026-10-30beat 1 review round

A split review marked each part as read the moment its calls went out, before any answer came back. When every call in a part failed, the record still counted its files as reviewed.

Record evidence after the work answers, not when it starts. A sent request proves nothing was read.

@sks24git2026-10-21

A modal panel moved to a shared primitive, and its old backdrop was a tracked button. The new backdrop closes the panel but carries no tracking attribute, so every close by backdrop click drops out of the metrics.

Carry tracking hooks across a primitive swap. Every old close path had an event; list them before you delete the markup.

@sks24git2026-10-21beat 2 review rounds

A status panel listed every note from the data layer as an alarm, including a plain freshness timestamp. A healthy system showed one alarm all day, and equal error texts from several blocks collided as list keys.

Build an alarm list from an allow-list of alarm kinds. A new info field turns into a false alarm.
Test the calm state too. A panel that is never empty on good data hides real alarms.

@sks24git2026-10-16beat 1 review round

A status screen marks a review as deep when a marker field is set, but the same field is also set while a deep request is still being sent. When the send fails, the screen reports a deep review that never ran.

Derive a flag from the final state, not from intent. Failed retries leave intent behind.
Test the failure path of every status flag. A flag that never goes false lies.

@sks24git2026-10-07

A size cap lets a job hand over 64 chunks, but the time rule lets the workers reach about 20. The rest are still counted as read, so the report claims full coverage nobody gave.

Count what was opened, not what was handed over. Input size and work time are two budgets.
Order work by weight. When the clock runs out, leave the lightest part unread.

@sks24git2026-09-05beat 2 review rounds

An alert deduped by an id cursor assumed the incident mark lands in id order, but another writer had inserted the row long before the mark arrived. The mark lands below the cursor and is never reported.

Key "already handled" to the fact, not a position. A cursor tracks write order; a flag on the row tracks the mark.
Make best-effort seams report delivery. Unit lets a lost page eat the retry.